added device list that support single and double ESIM.#382
Open
furiosFast wants to merge 3 commits intodevicekit:masterfrom
Open
added device list that support single and double ESIM.#382furiosFast wants to merge 3 commits intodevicekit:masterfrom
furiosFast wants to merge 3 commits intodevicekit:masterfrom
Conversation
Zandor300
requested changes
May 30, 2024
Member
Zandor300
left a comment
Zandor300
left a comment
There was a problem hiding this comment.
Is it possible for you to update your PR to include the dual eSim devices in the list for the single eSim devices. Could you also add tests for your changes and update from master?
|
|
||
| /// All devices that support dual ESIM. | ||
| public static var allDevicesWithDualEsimSupport: [Device] { | ||
| return [.iPhone13, .iPhone13Mini, .iPhone13Pro, .iPhone13ProMax, .iPhoneSE3, .iPhone14, .iPhone14Plus, .iPhone14Pro, .iPhone14ProMax, .iPhone15, .iPhone15Plus, .iPhone15Pro, .iPhone15ProMax] |
Member
There was a problem hiding this comment.
Sorry for my late reply. Why are the devices with dual eSim support not included in the single eSim list?
There was a problem hiding this comment.
There's an 11" iPad that is missing from the single sim list. Also, new 2024 iPads aren't in the list.
* master: Version bump. (v5.4.0) Add unknown orientation variant (devicekit#411) Version bump. (v5.3.1) Fix path for PrivacyInfo.xcprivacy in test target. Process Privacy manifest instead of copy on SPM. (devicekit#409) Version bump. (v5.3.0) Support for new May 2024 devices. (devicekit#412) Fix ruby version not found. (devicekit#414) Version bump. (v5.2.4) Enable MERGEABLE_LIBRARY. (devicekit#407) Update cocoapods to v1.15.2 in Gemfile. Release 5.2.3 fix: Use cocoapod resource_bundles for PrivacyInfo (devicekit#397) Fix building for visionOS. (devicekit#390) Fix building SwiftUI previews on macOS. (devicekit#389) Release 5.2.1 (devicekit#385) Fix PrivacyInfo.xcprivacy not being detected on SPM. (devicekit#384) Update swift-tools-version in Package.swift to 5.3 to support Resource files. (devicekit#381) # Conflicts: # Source/Device.swift.gyb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.